Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#201 Added net6 target to remove dependency on Microsoft.CS… #204

Merged
merged 2 commits into from
Feb 22, 2024
Merged

#201 Added net6 target to remove dependency on Microsoft.CS… #204

merged 2 commits into from
Feb 22, 2024

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jan 22, 2024 •
edited
Loading

Description

Adds a dotnet 6 target to allow for the removal of the Microsoft.CSharp reference for that framework and newer.

Fixes #201

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Simple compilation of project for new framework and ran unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@thompson-tomo thompson-tomo mentioned this pull request Jan 22, 2024
Closed
daveleek
daveleek requested changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @thompson-tomo! I would like you to change the .NET framework version you're adding to one that's still supported, like .NET 6.

This PR reminded us that we need some platform specific tests in place as well to be certain the SDK will continue to work on both .NET Framework and .NET Core platforms. I'll add an issue for that and we'll add it to planned work

src/Unleash/Unleash.csproj Outdated Show resolved Hide resolved
@daveleek daveleek mentioned this pull request Jan 24, 2024
Open
@thompson-tomo thompson-tomo changed the title #201 Added netcoreapp 3.1 target to remove dependency on Microsoft.CS… #201 Added net6 target to remove dependency on Microsoft.CS… Jan 24, 2024
@thompson-tomo @daveleek
Switch from netcoreapp 3.1 to net6
d76d864 
Co-authored-by: David Leek <davidekl@hotmail.com>
@thompson-tomo
Copy link
Contributor Author

@daveleek is there anything outstanding from me for this MR?

@daveleek
Copy link
Collaborator

Thank you @thompson-tomo! No you've done your part here. We're just going to add a build and a build step for verifying this continues to work on .NET Framework (windows) in the future!

@thompson-tomo
Copy link
Contributor Author

No worries @daveleek thanks for the update

daveleek
daveleek approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this and verify, we have some thoughts around future improvements but it's not a blocker

@daveleek daveleek merged commit 62409b3 into Unleash:main Feb 22, 2024
1 check passed
@thompson-tomo thompson-tomo deleted the enhancement/#201_AdditionalTarget branch February 22, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveleek daveleek daveleek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of Microsoft.CSharp package dependency
2 participants
@thompson-tomo @daveleek